build: remove service-* from default features#4311
Conversation
github-actions
bot
added
the
releases-note/build
| "services-webhdfs", | ||
| "services-azfile", | ||
| ] | ||
| default = ["rustls"] |
There was a problem hiding this comment.
not sure whether it's a good idea to remove rustls, so just keep it.
| "services-azblob", | ||
| "services-memory", | ||
| "services-http", |
There was a problem hiding this comment.
This affects a little dev experience. Now cargo test without --features tests cannot compile.
|
Other problems fixed. The only remaining issue is how to enable features for C bindings 🤔 BTW, does the released bindings contain all features? |
Most of C binding users will write their own |
|
In this PR, I think it's fine to add our default features in C binding directly: Lines 40 to 42 in a510291 |
| // Deny unused qualifications. | ||
| #![deny(unused_qualifications)] |
There was a problem hiding this comment.
This is because fuzz test failed to compile. quite weird. Anyway I don't think there's need to use the deny level.. warn is enough.
|
main CI failed. Let me fix it |
Thanks a lot! |
|
Maybe it's fine to enable memory service by default? |
That's acceptable to me. But I think it's suboptimal, since memory service isn't frequently used in production. 🤔 |
|
Oh, but memory service has very few code. Sounds better then. |
|
But what problems does it solve? Do you mean we just need memory service for CI? 🤔 I think we still need to consider what services to enable when release bindings. (BTW, I noticed that there's no much doc about how to enable features for bindings) |
They are determined by the owners of the bindings. Up to now, most bindings opt to include all services except for a few special ones.
Yes, we need to improve this part. |
2 participants
#4310
some implications:
cargo testcannot compile. Have tocargo test --features tests. This is a little bad. Maybe we can consider other ways e.g., gate unit tests withcfg(feature).I think the root cause is just the drawbacks of using feature flags, but less related with changing the default features.