Skip to content

Comments

RFC-3911: Deleter API#3911

Merged
Xuanwo merged 10 commits intomainfrom
delete-recursive
Jan 6, 2024
Merged

RFC-3911: Deleter API#3911
Xuanwo merged 10 commits intomainfrom
delete-recursive

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 4, 2024 •
edited
Loading

This RFC proposed deleter API to make the following usage happen:

// Init a deleter to start batch delete tasks.
let deleter = op.deleter().await?;
// List all files that ends with tmp
let lister = op.lister(path).await?
  .filter(|x|future::ready(x.ends_with(".tmp")));

// Forward all paths into deleter.
lister.forward(deleter).await?;

// Close the deleter.
deleter.close().await?;

@Xuanwo Xuanwo changed the title RFC: Deleter API RFC-3911: Deleter API Jan 4, 2024
suyanhanx
suyanhanx reviewed Jan 4, 2024
View reviewed changes
@Xuanwo Xuanwo requested review from G-XD, dqhl76, oowl and suyanhanx January 5, 2024 08:41
dqhl76
dqhl76 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xuanwo Xuanwo mentioned this pull request Jan 5, 2024
Open
18 tasks
@Xuanwo
Add tracking issues
2b05340 
Signed-off-by: Xuanwo <[email protected]>
suyanhanx
suyanhanx approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

oowl
oowl reviewed Jan 5, 2024
View reviewed changes
Xuanwo added 2 commits January 6, 2024 11:37
@Xuanwo
Reduce confusion
307f8b1 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix typo
5594629 
Signed-off-by: Xuanwo <[email protected]>
oowl
oowl approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xuanwo Xuanwo merged commit 470fc2f into main Jan 6, 2024
@Xuanwo Xuanwo deleted the delete-recursive branch January 6, 2024 03:43
@Xuanwo Xuanwo mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@oowl oowl oowl approved these changes

@dqhl76 dqhl76 dqhl76 approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

@G-XD G-XD Awaiting requested review from G-XD

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Xuanwo @suyanhanx @oowl @dqhl76