Skip to content

Comments

chore(ci): nodejs binding publish dry run#3632

Merged
Xuanwo merged 7 commits intomainfrom
rc-publish-dry-run
Nov 22, 2023
Merged

chore(ci): nodejs binding publish dry run#3632
Xuanwo merged 7 commits intomainfrom
rc-publish-dry-run

Conversation

@suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Nov 20, 2023

This pr adds a publish dry run for the nodejs binding.

@github-actions github-actions bot added the releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell label Nov 20, 2023
@suyanhanx
Copy link
Member Author

suyanhanx commented Nov 20, 2023

Requesting an update to execute cargo update and update the jsonwebtoken in reqsign to 9, to remove the [email protected] in our cargo.lock. This outdated crate is having trouble compiling on aarch64 win, and I can't fix this problem.
image
In fact, there is no [email protected] in [email protected]. The only one is imported by the jsonwebtoken in reqsign.

Other crates are using [email protected], which doesn't have a compiling problem.
cc @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2023

The only one is imported by the jsonwebtoken in reqsign.

We used to upgrade jsonwebtoken in reqsign to but failed for introducing two different version of ring which is not released in rustls.

Since https://github.com/rustls/rustls/releases/tag/v%2F0.21.8 has been released, it's time for us to try again.

@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2023

#3644 should fix the issue around reqsign.

But due to async-rs/async-tls#55, services-ftp is still blocked on old rustls. I think we can remove it from bindings (for java/nodejs/python) until it has been resolved.

Signed-off-by: suyanhanx <[email protected]>
@suyanhanx
Copy link
Member Author

suyanhanx commented Nov 22, 2023

image
Now they are all compiled and publish dry run successfully.

Thank you. @Xuanwo

Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
@suyanhanx suyanhanx marked this pull request as ready for review November 22, 2023 14:13
@suyanhanx suyanhanx requested a review from PsiACE as a code owner November 22, 2023 14:13
Signed-off-by: suyanhanx <[email protected]>
@Xuanwo Xuanwo merged commit be0853e into main Nov 22, 2023
@Xuanwo Xuanwo deleted the rc-publish-dry-run branch November 22, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants