feat(bindings/cpp): expose all api returned by value#3001
Merged
Conversation
Signed-off-by: silver-ymz <[email protected]>
Signed-off-by: silver-ymz <[email protected]>
Signed-off-by: silver-ymz <[email protected]>
suyanhanx
reviewed
Sep 1, 2023
Xuanwo
reviewed
Sep 1, 2023
Member
Author
|
Since all conversations have answers, could anyone give an approval? |
Signed-off-by: silver-ymz <[email protected]>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update:
is_exist,create_dir,copy,rename,remove,stat,list.Now it only remains
reader,writer,lister.About
Operator::read, I changed impl in #2984 becauseaddress sanitizeroutputscontainer overflow. But I found that this is a misinformation caused by missing sanitize option forlibopendal_cpp. As result, I revert previous impl. However, we still can't avoid copy because allstd::vectorpointer constructor use copy to hide internal structure.