Skip to content

Comments

feat(bindings/cpp): expose all api returned by value#3001

Merged
Xuanwo merged 4 commits intomainfrom
cpp-more-operation
Sep 2, 2023
Merged

feat(bindings/cpp): expose all api returned by value#3001
Xuanwo merged 4 commits intomainfrom
cpp-more-operation

Conversation

@silver-ymz
Copy link
Member

Update:

  1. expose is_exist, create_dir, copy, rename, remove, stat, list.
    Now it only remains reader, writer, lister.
  2. add valgrind in test ci to check more memory leak occasion
  3. add docs-only option to avoid install dependency in docs ci

About Operator::read, I changed impl in #2984 because address sanitizer outputs container overflow. But I found that this is a misinformation caused by missing sanitize option for libopendal_cpp. As result, I revert previous impl. However, we still can't avoid copy because all std::vector pointer constructor use copy to hide internal structure.

@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Sep 1, 2023
Signed-off-by: silver-ymz <[email protected]>
@silver-ymz
Copy link
Member Author

Since all conversations have answers, could anyone give an approval?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 1dfc7e6 into main Sep 2, 2023
@Xuanwo Xuanwo deleted the cpp-more-operation branch September 2, 2023 13:34
@silver-ymz silver-ymz mentioned this pull request Sep 1, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants