Skip to content

Comments

test(services/tikv): add tikv integration test#2693

Merged
Xuanwo merged 19 commits intoapache:mainfrom
oowl:test/service/tikv
Jul 24, 2023
Merged

test(services/tikv): add tikv integration test#2693
Xuanwo merged 19 commits intoapache:mainfrom
oowl:test/service/tikv

Conversation

@oowl
Copy link
Member

@oowl oowl commented Jul 23, 2023

No description provided.

@oowl oowl requested review from PsiACE and Xuanwo as code owners July 23, 2023 11:36
@Xuanwo
Copy link
Member

Xuanwo commented Jul 23, 2023

shrink/actions-docker-extract@v1 is not allowed to be used in apache/incubator-opendal

Approval from ASF Infra is required to use external workflows. Actions such as shrink/actions-docker-extract@v1, which have only 11 stars, were last updated in last year, and have no known users, are highly possible to be rejected.

I suggest to use the same tikv-client used for testing:

- name: install tiup
  run: curl --proto '=https' --tlsv1.2 -sSf https://tiup-mirrors.pingcap.com/install.sh | sh
- name: start tiup playground
  run: |
    # use latest stable version
    ~/.tiup/bin/tiup install tikv pd
    ~/.tiup/bin/tiup playground --mode tikv-slim --kv 3 --without-monitor --kv.config config/tikv.toml --pd.config config/pd.toml &
    while :; do
      echo "waiting cluster to be ready"
      [[ "$(curl -I http://127.0.0.1:2379/pd/api/v1/regions 2>/dev/null | head -n 1 | cut -d$' ' -f2)" -ne "405" ]] || break
      sleep 1
    done

ref: https://github.com/tikv/client-rust/blob/master/.github/workflows/ci.yml

@oowl
Copy link
Member Author

oowl commented Jul 23, 2023

Hi @Xuanwo , I can not trigger the newer tikv action in the current PR, Do you know how to start it?

@Xuanwo
Copy link
Member

Xuanwo commented Jul 23, 2023

Hi @Xuanwo , I can not trigger the newer tikv action in the current PR, Do you know how to start it?

Actions that refer to disallowed actions will be automatically rejected. There is no way to activate them. Please remove shrink/actions-docker-extract@v1.

Xuanwo
Xuanwo previously approved these changes Jul 23, 2023
@Xuanwo Xuanwo dismissed their stale review July 23, 2023 15:10

Wrong click

@oowl
Copy link
Member Author

oowl commented Jul 23, 2023

I can not find how to use tiup playground with TLS configuration, So I skip tikv TLS integration test. we can consider adding it in the future PR.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Xuanwo Xuanwo merged commit c5c670f into apache:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants