Skip to content

Comments

feat: Implement sink for services s3#2508

Merged
Xuanwo merged 11 commits intomainfrom
implement-sink-for-s3
Jun 23, 2023
Merged

feat: Implement sink for services s3#2508
Xuanwo merged 11 commits intomainfrom
implement-sink-for-s3

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 21, 2023

This is a very basic implement of sink. And it's not play well with our existing features like append or write. We will improve it in later PRs.

Close #2441
Part of #2084

@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jun 21, 2023
@Xuanwo Xuanwo requested review from suyanhanx and xyjixyjixyji June 21, 2023 10:59
Signed-off-by: Xuanwo <[email protected]>
@suyanhanx
Copy link
Member

Where's the content of #2441? 🤔

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 21, 2023

Where's the content of #2441? thinking

Fixed by changing #2441

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo requested review from suyanhanx and xyjixyjixyji June 23, 2023 03:00
@Xuanwo Xuanwo merged commit 39e8837 into main Jun 23, 2023
@Xuanwo Xuanwo deleted the implement-sink-for-s3 branch June 23, 2023 05:13
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sink API for Writer

4 participants