-
Notifications
You must be signed in to change notification settings - Fork 717
Closed
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededrustPull requests that update Rust codePull requests that update Rust code
Description
#5480 has implemented everything we need to context API. This issues is used to track the progress of migrating all services to context based.
The migration itself is simple, we just need to use the HttpClient fomr AccessorInfo instead of backend directly, for example:
diff --git a/core/src/services/s3/core.rs b/core/src/services/s3/core.rs
index d4375b520b6..173a33d50ef 100644
--- a/core/src/services/s3/core.rs
+++ b/core/src/services/s3/core.rs
@@ -101,7 +101,6 @@ pub struct S3Core {
pub signer: AwsV4Signer,
pub loader: Box<dyn AwsCredentialLoad>,
pub credential_loaded: AtomicBool,
- pub client: HttpClient,
pub checksum_algorithm: Option<ChecksumAlgorithm>,
}
@@ -198,7 +197,7 @@ impl S3Core {
#[inline]
pub async fn send(&self, req: Request<Buffer>) -> Result<Response<Buffer>> {
- self.client.send(req).await
+ self.info.http_client().send(req).await
}
/// # Note
@@ -503,7 +502,7 @@ impl S3Core {
self.sign(&mut req).await?;
- self.client.fetch(req).await
+ self.info.http_client().fetch(req).await
}
pub fn s3_put_object_request(The whole change could be seen at #5676
All http based services will need this change.
Services
- S3: refactor: Migrate s3 services to context based http client #5676
- aliyun_drive: refactor: Migrate aliyun_drive services to context based http client #5815
- azfile: refactor: Migrate azfile services to context based http client #5816
- dropbox: refactor: Migrate dropbox services to context based http client #5827
- gcs: refactor(gcs): Migrate to context based http client #5778
- refactor: Migrate oss services to context based http client #5681
- upyun: refactor: Migrate upyun services to context based http client #5829
- yandex_disk: refactor: Migrate yandex_disk services to context based http client #5841
- alluxio: refactor: Migrate alluxio services to context based http client #5842
- b2: refactor: Migrate b2 service to context based http client #5843
- refactor: Migrate cos services to context based http client #5683
- gdrive: refactor: Migrate gdrive service to context based http client #5861
- pcloud: refactor: Migrate pcloud service to context based http client #5866
- vercel_artifacts: refactor: Migrate vercel_artifacts service to context based http client #5877
- refactor: Migrate services to context based http client #5882
- ghac
- koofr
- vercel_blob
- azblob
- huggingface
- lakefs
- seafile
- swift
- webdav
- azdls
- http: refactor: Migrate http service to context based http client #5879
- github: refactor: Migrate github services to context based http client #5764
- refactor: Migrate obs services to context based http client #5682
- icloud: refactor: Migrate icloud service to context based http client #5891
- onedrive: feat(services/onedrive): add signer to utilize the refresh token #5733
- webhdfs: refactor: Migrate WebHDFS service to context based http client #5893
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededrustPull requests that update Rust codePull requests that update Rust code