Skip to content

Commit f18fdff

Browse files
authored
feat(dev): support dotnet version updates (#7862)
1 parent 10b1636 commit f18fdff

1 file changed

Lines changed: 82 additions & 0 deletions

File tree

‎dev/src/release/package.rs‎

Lines changed: 82 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ pub fn all_packages() -> Vec<Package> {
7878
let nodejs = make_package("bindings/nodejs", "0.49.4", vec![core.clone()]);
7979
let python = make_package("bindings/python", "0.47.2", vec![core.clone()]);
8080
let ruby = make_package("bindings/ruby", "0.1.7", vec![core.clone()]);
81+
let dotnet = make_package("bindings/dotnet", "0.1.0", vec![core.clone()]);
8182

8283
vec![
8384
core,
@@ -91,6 +92,7 @@ pub fn all_packages() -> Vec<Package> {
9192
nodejs,
9293
python,
9394
ruby,
95+
dotnet,
9496
]
9597
}
9698

@@ -120,6 +122,7 @@ pub fn update_package_version(package: &Package) -> bool {
120122
}
121123
"bindings/java" => update_maven_version(&package.path, &package.version),
122124
"bindings/nodejs" => update_nodejs_version(&package.path, &package.version),
125+
"bindings/dotnet" => update_dotnet_version(&package.path, &package.version),
123126

124127
name => panic!("unknown package: {name}"),
125128
}
@@ -521,6 +524,33 @@ fn update_nodejs_version(path: &Path, version: &Version) -> bool {
521524
updated
522525
}
523526

527+
fn update_dotnet_version(path: &Path, version: &Version) -> bool {
528+
let path = path.join("OpenDAL").join("OpenDAL.csproj");
529+
let manifest = std::fs::read_to_string(&path).unwrap();
530+
let matcher = regex::Regex::new(r"<VersionPrefix>(\d+\.\d+\.\d+)</VersionPrefix>").unwrap();
531+
let old_version = matcher
532+
.captures(&manifest)
533+
.and_then(|captures| captures.get(1))
534+
.map(|matched| Version::parse(matched.as_str()).unwrap())
535+
.unwrap_or_else(|| panic!("missing VersionPrefix for package: {}", path.display()));
536+
537+
if old_version == *version {
538+
return false;
539+
}
540+
541+
let new_version_string = format!("<VersionPrefix>{version}</VersionPrefix>");
542+
let new_manifest = matcher.replace(&manifest, new_version_string.as_str());
543+
std::fs::write(&path, new_manifest.as_bytes()).unwrap();
544+
println!(
545+
"updating version for package: {} from {} to {}",
546+
path.display(),
547+
old_version,
548+
version
549+
);
550+
551+
true
552+
}
553+
524554
#[cfg(test)]
525555
mod tests {
526556
use super::*;
@@ -553,6 +583,17 @@ mod tests {
553583
.unwrap()
554584
}
555585

586+
fn dotnet_project_version(package: &Package) -> Version {
587+
let manifest_path = package.path.join("OpenDAL").join("OpenDAL.csproj");
588+
let manifest = std::fs::read_to_string(manifest_path).unwrap();
589+
let matcher = regex::Regex::new(r"<VersionPrefix>(\d+\.\d+\.\d+)</VersionPrefix>").unwrap();
590+
matcher
591+
.captures(&manifest)
592+
.and_then(|captures| captures.get(1))
593+
.map(|matched| Version::parse(matched.as_str()).unwrap())
594+
.unwrap()
595+
}
596+
556597
#[test]
557598
fn parquet_release_version_matches_manifest() {
558599
let parquet = release_package("integrations/parquet");
@@ -567,6 +608,13 @@ mod tests {
567608
assert_eq!(ruby.version, cargo_manifest_version(&ruby));
568609
}
569610

611+
#[test]
612+
fn dotnet_release_version_matches_project() {
613+
let dotnet = release_package("bindings/dotnet");
614+
615+
assert_eq!(dotnet.version, dotnet_project_version(&dotnet));
616+
}
617+
570618
#[test]
571619
fn update_manifest_version_supports_workspace_package_version() {
572620
let mut manifest = DocumentMut::from_str(
@@ -667,6 +715,40 @@ opendal = { version = "0.55.0", path = "../core" }
667715
std::fs::remove_dir_all(dir).unwrap();
668716
}
669717

718+
#[test]
719+
fn update_dotnet_version_updates_version_prefix() {
720+
let dir = temp_test_dir("dotnet-version");
721+
let project_dir = dir.join("OpenDAL");
722+
std::fs::create_dir_all(&project_dir).unwrap();
723+
724+
let project_path = project_dir.join("OpenDAL.csproj");
725+
std::fs::write(
726+
&project_path,
727+
r#"<Project Sdk="Microsoft.NET.Sdk">
728+
<PropertyGroup>
729+
<VersionPrefix>0.1.0</VersionPrefix>
730+
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
731+
<FileVersion>$(VersionPrefix)</FileVersion>
732+
</PropertyGroup>
733+
</Project>"#,
734+
)
735+
.unwrap();
736+
737+
let updated = update_dotnet_version(&dir, &Version::parse("0.2.0").unwrap());
738+
assert!(updated);
739+
740+
let manifest = std::fs::read_to_string(&project_path).unwrap();
741+
assert!(manifest.contains("<VersionPrefix>0.2.0</VersionPrefix>"));
742+
assert!(manifest.contains("<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>"));
743+
assert!(manifest.contains("<FileVersion>$(VersionPrefix)</FileVersion>"));
744+
assert!(!update_dotnet_version(
745+
&dir,
746+
&Version::parse("0.2.0").unwrap()
747+
));
748+
749+
std::fs::remove_dir_all(dir).unwrap();
750+
}
751+
670752
#[test]
671753
fn sync_workspace_internal_dependency_versions_updates_workspace_path_dependencies() {
672754
let dir = temp_test_dir("workspace-sync");

0 commit comments

Comments
 (0)