Fix EL ResourceBundle preview panel - #8603
Conversation
mbien
added
Editor
enterprise
|
Marking this as draft as there's another fix I'd like to make about bundle resolution |
|
nice! I like those quality of life improvements. |
Fix "Open source in editor button" Fix loading of bundle files from default package @
3fcc795 to
15bc036
Compare
mbien
left a comment
mbien
left a comment
There was a problem hiding this comment.
looks good, thanks for the improvements!
I put NB27 milestone on it and will wait a bit in case other reviewers would like to take a look too. Dev builds for manual testing are available on the workflow runs, e.g last (scroll down for artifacts).
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. I thought, that the "Open source in editor" should jump to the right line. But that would require a parser for "text/x-properties" to be present, which is not the case. If that is added in the future, it should be possible to change the ElResourceBundleKeyCompletionItem constructor to take a org.netbeans.modules.web.el.ResourceBundles.Location instead of a FileObject and then use the offset coded in that location report that as "OffsetRange".
So at this point in time I think this is good to go and indeed a nice improvement.
@mbien do you want to merge?
|
lets merge, @NicolaIsotta thanks again! |
3 participants
Before:
After:
This also makes the "Open source in editor button" work and fixes the loading of bundle files from the default package / root folder.
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)