Add global maven goal presets - #7537
Conversation
mbien
added
Maven
|
Looks good! Ideally would have a link to |
73b033c to
2448b58
Compare
|
@neilcsmith-net updated the screenshot, let me know what you think |
|
Thanks! Think that works and a good change for NB23. We could perhaps (in future!) standardize some of the terminology here. We use Goals and Actions in different places, and neither entirely overlaps with Maven's concept of Goal. |
|
we would probably have to call it "action" everywhere to be technically correct, since Its just that goal is the more familiar term most likely, so if it happens to support phases it is probably ok to call the menu entry point "Edit Goals..."? I would probably leave it as is for now tbh but I would also have no problem to change it to "Edit Actions...". |
|
refreshing since dev build expired |
2448b58 to
e376b6a
Compare
| --> | ||
| <actions> | ||
| <action> | ||
| <actionName>CUSTOM-Add/Update Wrapper (mvnw)</actionName> |
There was a problem hiding this comment.
I'd recommend to use identifier-like action names. These CUSTOM- are used in user-defined actions in the userdir.
There was a problem hiding this comment.
I considered this but if they don't have the prefix, they won't show up.
and secondly: as soon a user adds/removes/edits them, the action definitions will be copied to the user dir as-is.
The action presets are essentially custom actions which aren't in the user dir yet. If the user has a nbactions.xml already won't be merged with it - so they are no defaults in the classic sense.
|
planning to merge this before freeze |
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Change looks sane to me. We could do a bit of bikeshedding about what are worthy default goals, but they are not totally of what I would expect.
- add mvnw updater and a few maveniverse toolbox diagnostic goals as global preset - add right click menu actions which lead to the global and project rule editors for easy add/edit/remove - some layout adjustments to both global and custom goal windows so that they resize nicely - minor language level cleanup
mbien
removed
the
ci:dev-build
e376b6a to
d136c79
Compare
4 participants
mvnwupdater and a few maveniverse toolbox diagnostic goals as global preset"Edit Global Goals" (new) will open the (already existing) window:
(also accessible from maven execution options)
note:
I reverted a few things to not change too much at once. What I originally planned was to combine the global and per-project goal editor windows and I wanted to move the global editor panel to a card in the main maven options. However, the problem is that the two windows and the tools->options windows have different ways how to handle persistence, so this would have been too much at once. Still something we can do at some point.