[NETBEANS-3427] Import Dark Metal and Dark Nimbus LaF from Oracle Donation 4 #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the 4th Oracle Donation Source: https://hg.netbeans.org/releases/raw-file/tip/ApacheDonation4.zip SHA512: 981ad23f81d6e3bca506c307b737baadde74481931482f6ede9a9a62af77c9ba4066e9846eb83584a5a2de296f1f00d9b0fe7371fad832175de2a7b46c79ed47 Checked against the information provided in: https://lists.apache.org/thread.html/66e82f9c6288d4f7594e934edfa25e2c917bed351e6fac75eeeee51d@%3Cprivate.netbeans.apache.org%3E
Contributor
Author
|
|
jkovalsky
approved these changes
Nov 23, 2019
Contributor
jkovalsky
left a comment
jkovalsky
left a comment
There was a problem hiding this comment.
I would only suggest to change HTTP protocol to HTTPS in all links to Apache License terms i.e. https://www.apache.org/licenses/LICENSE-2.0 otherwise I like to work!
lkishalmi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just did the necessary modifications for the import. Changing license headers, and include the module into the build chain.
Right now the module automatically switches to Dark Metal on install, also the java level can be moved from 6 -> 8. I think that could be dealt with later when this "historical" import PR got merged.