host/svc: add IPSS service for IPSP support#392
Merged
rymanluk merged 1 commit intoapache:masterfrom Apr 26, 2019
Merged
Conversation
This was referenced Mar 27, 2019
Member
Author
|
any chance someone wants review this? |
rymanluk
approved these changes
Apr 26, 2019
Contributor
rymanluk
left a comment
rymanluk
left a comment
There was a problem hiding this comment.
@haukepetersen Sorry for late review. Service itself looks good, thanks. However, as you might agree, it is not very useful for others :) Would you come up also with profile implementation - even as a test application?
Member
Author
|
@rymanluk thanks for merging! I do have a test application, it is however tightly coupled to RIOT and its GNRC network stack. The PR will be out somewhere in Mai. I'll let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the IPSS (Inernet protocol support service) to NimBLE. This service is defined in the IPSP (Internet Protocol Support Profile) spec. It has not characteristics and is simply there to notify others on a node's capability to run IP traffic (over l2cap coc).
I tested this PR using RIOT using this branch: https://github.com/haukepetersen/RIOT/tree/add_nimble_ipsp and building with
USEMODULE=nimble_svc_ipss. Only problem is, that one has to manually set the RIOT package to this branch...This setup does so far only configure this trivial service for a device, it does not yet enable the actual IP-over-BLE capabilities. These i will PR separately to RIOT.