Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@josephevans
Copy link
Contributor

No description provided.

Copy link

@DickJC123 DickJC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support the idea of making Ampere GPUs available to the CI to continually validate MXNet's operation in the presence of Tensorfloat-32 (TF32) math. My approval is based on the intent of this PR, as I lack the jenkins experience to critique the added code lines.

I see that you've added mxnetlinux-gpu-g5, similar to the mxnetlinux-gpu-g4. There's also a restricted-mxnetlinux-gpu-g4, but you've not added a restricted-mxnetlinux-gpu-g5. How are restricted-* definitions used, i.e. what's the impact of not having a restricted-mxnetlinux-gpu-g5?

@josephevans
Copy link
Contributor Author

I see that you've added mxnetlinux-gpu-g5, similar to the mxnetlinux-gpu-g4. There's also a restricted-mxnetlinux-gpu-g4, but you've not added a restricted-mxnetlinux-gpu-g5. How are restricted-* definitions used, i.e. what's the impact of not having a restricted-mxnetlinux-gpu-g5?

Thanks for the review. The restricted nodes are used for CD processes that require different permissions (such as publishing artifacts somewhere,) we shouldn't need a restricted node for this node type at this point. If it becomes needed down the road, we can add it.

@josephevans josephevans merged commit 550f1db into apache:master Feb 8, 2022
@josephevans josephevans deleted the add_g5 branch February 8, 2022 06:09
@DickJC123
Copy link

Thanks for this additional capability. As I work to get MXNet CI using this new facility, is it also important to mention mxnetlinux-gpu-g5 in environment.yml, e.g. in lines like: https://github.com/apache/incubator-mxnet-ci/blob/master/services/jenkins-autoscaling/lambda_mxnet_ci/autoscaling/environment.yml#L15?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants