This repository was archived by the owner on Nov 17, 2023. It is now read-only.
forbid setattr type changes and enable block replacement #7667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiswrong
reviewed
Aug 30, 2017
python/mxnet/gluon/block.py
Outdated
| type2=type(value))) | ||
| if isinstance(existing, Block): | ||
| for i, c in enumerate(self._children): | ||
| if c == existing: |
Contributor
|
Please add tests for these new behaviors |
piiswrong
reviewed
Aug 31, 2017
tests/python/unittest/test_gluon.py
Outdated
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| import unittest |
piiswrong
reviewed
Aug 31, 2017
| if hasattr(self, name): | ||
| existing = getattr(self, name) | ||
| if not name.startswith('_') and not isinstance(value, type(existing)): | ||
| raise TypeError('Changing attribute type for {name} from {type1} to {type2}' \ |
Contributor
There was a problem hiding this comment.
Let's restrict the check to Parameter and Block.
Member
Author
There was a problem hiding this comment.
Existing attribute value can be NoneType and later changes to Block or Parameter. Should this be allowed?
mbaijal
pushed a commit
to mbaijal/incubator-mxnet
that referenced
this pull request
Sep 6, 2017
* forbid setattr type changes and enable block replacement * update per comment * add tests * protect block and param
cjolivier01
pushed a commit
to cjolivier01/mxnet
that referenced
this pull request
Sep 11, 2017
* forbid setattr type changes and enable block replacement * update per comment * add tests * protect block and param
crazy-cat
pushed a commit
to crazy-cat/incubator-mxnet
that referenced
this pull request
Oct 26, 2017
* forbid setattr type changes and enable block replacement * update per comment * add tests * protect block and param
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change includes: