Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Port #20810 from master #20839

Merged
josephevans merged 2 commits into from
Jan 27, 2022
Merged

[v1.x] Port #20810 from master #20839

josephevans merged 2 commits into from
Jan 27, 2022

Conversation

@josephevans
Copy link
Contributor

@josephevans josephevans commented Jan 24, 2022

Port #20810 from master into v1.x branch.

@josephevans josephevans requested a review from szha as a code owner January 24, 2022 23:19
@mxnet-bot
Copy link

mxnet-bot commented Jan 24, 2022

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, miscellaneous, windows-gpu, clang, website, sanity, centos-gpu, centos-cpu, windows-cpu, unix-cpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jan 24, 2022
@josephevans josephevans requested a review from ptrendx January 24, 2022 23:32
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 25, 2022
ptrendx
ptrendx approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@ptrendx ptrendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 26, 2022
@josephevans josephevans merged commit 2e2d717 into apache:v1.x Jan 27, 2022
@josephevans josephevans deleted the v1.x_port_20810 branch January 27, 2022 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@ptrendx ptrendx ptrendx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josephevans @mxnet-bot @ptrendx @mseth10