Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@josephevans
Copy link
Contributor

Backport #20598 from v1.9.x to v1.x.

Fix the first 3 items in #20616

  • Remove ASF2.0 license and properly list under 3-clause BSD files in LICENSE for np_einsum files.
  • Fix license category for deformable_convolution files.
  • Update list of Apache-2.0 licensed files.
  • Add files to LICENSE that fall under Apache 2.0 license.
  • Add include symlinks and other ASF2 files to LICENSE.
  • Remove extra line.
  • Add numpy einsum files (licensed under bsd 3-clause) to rat-excludes.
  • Mention include/nnvm in LICENSE file.
  • Remove files from LICENSE with clear ASF-2.0 license headers, added by accident based on skywalking-eyes faulty results.
  • Move header guards to below license header section, so skywalking-eyes tool recognizes ASF-2.0 header.
  • Fix formatting with license header.
  • Fix license section for FindJeMalloc.cmake, move protoc-gen-mypy.py to Apache-2.0 licensed files.
  • Clearly indicate caffe subdirectory's licensing model in LICENSE.
  • Add skywalking-eyes config to repo.
  • Add skywalking-eyes config (.licenserv.yaml) to rat-excludes.
  • Add skywalking-eyes license checker into Github workflow.
  • Remove caffe subdir from LICENSE and license-check config whitelist, since it is no longer in the repo.
  • Remove duplicate entries in LICENSE - leave in Caffe license section.

Fix the first 3 items in apache#20616

* Remove ASF2.0 license and properly list under 3-clause BSD files in LICENSE for np_einsum files.

* Fix license category for deformable_convolution files.

* Update list of Apache-2.0 licensed files.

* Add files to LICENSE that fall under Apache 2.0 license.

* Add include symlinks and other ASF2 files to LICENSE.

* Remove extra line.

* Add numpy einsum files (licensed under bsd 3-clause) to rat-excludes.

* Mention include/nnvm in LICENSE file.

* Remove files from LICENSE with clear ASF-2.0 license headers, added by accident based on skywalking-eyes faulty results.

* Move header guards to below license header section, so skywalking-eyes tool recognizes ASF-2.0 header.

* Fix formatting with license header.

* Fix license section for FindJeMalloc.cmake, move protoc-gen-mypy.py to Apache-2.0 licensed files.

* Clearly indicate caffe subdirectory's licensing model in LICENSE.

* Add skywalking-eyes config to repo.

* Add skywalking-eyes config (.licenserv.yaml) to rat-excludes.

* Add skywalking-eyes license checker into Github workflow.

* Remove caffe subdir from LICENSE and license-check config whitelist, since it is no longer in the repo.

* Remove duplicate entries in LICENSE - leave in Caffe license section.
@josephevans josephevans requested a review from szha as a code owner September 29, 2021 22:49
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, centos-cpu, unix-cpu, clang, windows-gpu, windows-cpu, miscellaneous, unix-gpu, website, edge, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Sep 29, 2021
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review pr-work-in-progress PR is still work in progress labels Sep 30, 2021
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@josephevans josephevans merged commit 695ff99 into apache:v1.x Sep 30, 2021
@josephevans josephevans deleted the license_fixes_v1.x branch September 30, 2021 23:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants