Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy]Fix einsum issue #18102 #18419

Merged
sxjscience merged 4 commits into from
Jun 3, 2020
Merged

[Numpy]Fix einsum issue #18102 #18419

sxjscience merged 4 commits into from
Jun 3, 2020

Conversation

@hanke580
Copy link
Contributor

@hanke580 hanke580 commented May 27, 2020

Description

Fix einsum gradient bug in Issue #18102

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

mxnet-bot commented May 27, 2020

Hey @hanke580 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, centos-gpu, clang, centos-cpu, edge, miscellaneous, sanity, website, windows-cpu, unix-gpu, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@sxjscience
Copy link
Member

sxjscience commented Jun 1, 2020

@hanke580 Would you fix the lint check and add some test cases?

@hanke580
Copy link
Contributor Author

hanke580 commented Jun 1, 2020

Sure, tests adding

@hanke580 hanke580 force-pushed the einsum branch 2 times, most recently from 4dd7cf4 to 3802104 Compare June 3, 2020 08:29
@hanke580 hanke580 mentioned this pull request Jun 3, 2020
Closed
sxjscience
sxjscience approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxjscience sxjscience merged commit 8d220a2 into apache:master Jun 3, 2020
@leezu
Copy link
Contributor

leezu commented Jun 3, 2020

This looks like something we should backport to 1.6, 1.7, 1.x branches @hanke580 @sxjscience?

cc @ciyongch

@leezu leezu added the R1.7.0 label Jun 3, 2020
@sxjscience
Copy link
Member

sxjscience commented Jun 3, 2020

It should be backported to 1.7.

@ciyongch
Copy link
Contributor

ciyongch commented Jun 4, 2020

Hi @hanke580 , can you help to backport this PR to v1.7.x branch as suggested by @sxjscience and @leezu , and tag me in the new PR? Thanks.

@hanke580
Copy link
Contributor Author

hanke580 commented Jun 4, 2020

Sure @ciyongch

@hanke580 hanke580 mentioned this pull request Jun 4, 2020
Merged
7 tasks
yijunc pushed a commit to yijunc/incubator-mxnet that referenced this pull request Jun 9, 2020
@hanke580 @yijunc
[Numpy]Fix einsum issue apache#18102 (apache#18419)
2ab221c 
* * Fix einsum Bug

* * Fix sanity

* * Fix one dim start bug

* * Fix test case gt
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@hanke580 @AntiZpvoh
[Numpy]Fix einsum issue apache#18102 (apache#18419)
18518a3 
* * Fix einsum Bug

* * Fix sanity

* * Fix one dim start bug

* * Fix test case gt
@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Sep 20, 2020

@sxjscience Why isn't this backported to v1.x branch? Any specific reason or just a miss?

@sxjscience
Copy link
Member

sxjscience commented Sep 20, 2020

It's just a miss.

@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Sep 20, 2020

Can we get a cherry-pick for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sxjscience sxjscience sxjscience approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

R1.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hanke580 @mxnet-bot @sxjscience @leezu @ciyongch @ChaiBapchya