Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

pin Sphinx due to autodocsumm issue with v2.4.0 #17561

Merged
haojin2 merged 1 commit into from
Feb 12, 2020
Merged

pin Sphinx due to autodocsumm issue with v2.4.0 #17561

haojin2 merged 1 commit into from
Feb 12, 2020

Conversation

@aaronmarkham
Copy link
Contributor

@aaronmarkham aaronmarkham commented Feb 11, 2020 •
edited
Loading

Description ##https://github.com/apache/incubator-mxnet/pull/17561/commits

Fixes #17560

Comin' in 🌶 - haven't had a chance to run it through the full tests yet, but this issue is blocking, so let's see what CI thinks!

Edit: The reason I chose 2.2.2 is that 2.2.x was the latest version that was passing autodocsumm's CI. And v2.2.2 is the latest minor version of Sphinx offered on PyPi.

@aaronmarkham aaronmarkham requested a review from szha as a code owner February 11, 2020 01:27
samskalicky
samskalicky approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got some skills @aaronmarkham! Not sure how setting 2.2.2 results in:

[2020-02-11T07:37:34.895Z] [07:37:33] C:\jenkins_slave\workspace\build-gpu\src\resource.cc:279: Ignore CUDA Error [07:37:33] c:\jenkins_slave\workspace\build-gpu\src\storage\./pooled_storage_manager.h:97: CUDA: 
[2020-02-11T07:37:34.895Z] unspecified launch failure

But if anybody can break GPUs with 2's its you...I restarted the job

@aaronmarkham
Copy link
Contributor Author

aaronmarkham commented Feb 11, 2020

You got some skills @aaronmarkham! Not sure how setting 2.2.2 results in:

[2020-02-11T07:37:34.895Z] [07:37:33] C:\jenkins_slave\workspace\build-gpu\src\resource.cc:279: Ignore CUDA Error [07:37:33] c:\jenkins_slave\workspace\build-gpu\src\storage\./pooled_storage_manager.h:97: CUDA: 
[2020-02-11T07:37:34.895Z] unspecified launch failure

But if anybody can break GPUs with 2's its you...I restarted the job

failure-to-launch

Let's put in v🥈. 🥈. 🥈

ChaiBapchya
ChaiBapchya approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged! Retriggered the windows-gpu job!

@leezu
Copy link
Contributor

leezu commented Feb 11, 2020

Retriggerd failled CI job

@aaronmarkham aaronmarkham changed the title pin Sphinx due to autodocsumm issue with v4.2.0 pin Sphinx due to autodocsumm issue with v2.4.0 Feb 11, 2020
@leezu
Copy link
Contributor

leezu commented Feb 11, 2020

@aaronmarkham let's not change the title to avoid re-triggering all CI jobs. It's better to just re-trigger the failed job

@aaronmarkham
Copy link
Contributor Author

aaronmarkham commented Feb 11, 2020

@aaronmarkham let's not change the title to avoid re-triggering all CI jobs. It's better to just re-trigger the failed job

Doh! I forgot it did that. Lame.

@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Feb 12, 2020

@mxnet-label-bot add [pr-awaiting-merge]
Once windows gpu passes good to go!

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Feb 12, 2020
@haojin2 haojin2 merged commit bdd34e9 into apache:master Feb 12, 2020
@Chilipp
Copy link

Chilipp commented Feb 13, 2020

hey @aaronmarkham: This PR can be reverted as the new version of autodocsumm (0.1.12) works well with sphinx 2.4.0 (see Chilipp/autodocsumm#22 (comment))

@aaronmarkham
Copy link
Contributor Author

aaronmarkham commented Feb 13, 2020

hey @aaronmarkham: This PR can be reverted as the new version of autodocsumm (0.1.12) works well with sphinx 2.4.0 (see Chilipp/autodocsumm#22 (comment))

Awesome! I'll try it out. Thanks @Chilipp

@aaronmarkham aaronmarkham mentioned this pull request Feb 14, 2020
Merged
leezu pushed a commit to leezu/mxnet that referenced this pull request Feb 15, 2020
@aaronmarkham @leezu
pin Sphinx due to autodocsumm issue with v4.2.0 (apache#17561)
6caa5a2
leezu added a commit that referenced this pull request Feb 17, 2020
@leezu @haojin2 @aaronmarkham
Backport #17596 (#17603)
4da66fa 
* Fix transformer.cu interleaved matmul for cuda arch < 5  (#17596)

cublasGemmBatchedEx is only supported for GPU with architecture capabilities equal or greater than 5.0.

Fixes a bug in #16408

* pin Markdown version to 3.1 in Julia doc build (#17549)

* pin Sphinx due to autodocsumm issue with v4.2.0 (#17561)

* pin python dependencies (#17556)

* [CI] Fix static build pipeline (#17474)

* 1.5.x CI fixes (#17426)

* Fix numpy decorator

* Workaround pytest-dev/pytest#5903

* Disable pylint warnings

* Fix Edge build

* Fix numpy decorator on Centos

* Follow redirects when downloading apache-maven-3.3.9-bin.tar.gz

Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Aaron Markham <[email protected]>
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
@aaronmarkham
pin Sphinx due to autodocsumm issue with v4.2.0 (apache#17561)
bb72398
@aaronmarkham aaronmarkham added Doc and removed pr-awaiting-merge Review and CI is complete. Ready to Merge labels Apr 17, 2020
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@aaronmarkham @anirudh2290
pin Sphinx due to autodocsumm issue with v4.2.0 (apache#17561)
e49743a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

3 more reviewers

@samskalicky samskalicky samskalicky approved these changes

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@TEChopra1000 TEChopra1000 TEChopra1000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Doc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ci] [docs] Error blocking all PRs: autodocsumm is incompatible with Sphinx 2.4.0

8 participants

@aaronmarkham @leezu @ChaiBapchya @Chilipp @samskalicky @TEChopra1000 @haojin2 @lanking520