Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[LICENSE] fix cpp predcit license #17377

Merged
eric-haibin-lin merged 4 commits into from
Jan 27, 2020
Merged

[LICENSE] fix cpp predcit license #17377

eric-haibin-lin merged 4 commits into from
Jan 27, 2020

Conversation

@eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Jan 18, 2020

Description

Update the license to apache 2.0.

@skylook could you approve it?

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin
Copy link
Member Author

eric-haibin-lin commented Jan 18, 2020

#17329

@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Jan 19, 2020

nitpick typo in the title :p
But let's not change it coz it will retrigger the CI :(

@skylook
Copy link
Contributor

skylook commented Jan 19, 2020

Yes, I approved. Thx @eric-haibin-lin

roywei
roywei reviewed Jan 20, 2020
View reviewed changes
Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed to mention we need to add this file in license check exclusion. As it's using normal Apache2.0 instead of ASF license header.

Please add the file path in the following 2 files to exclude from header check:
https://github.com/apache/incubator-mxnet/blob/master/tools/license_header.py#L64
https://github.com/apache/incubator-mxnet/blob/master/tests/nightly/apache_rat_license_check/rat-excludes#L78

@eric-haibin-lin eric-haibin-lin merged commit 3ef8935 into apache:master Jan 27, 2020
@eric-haibin-lin
Copy link
Member Author

eric-haibin-lin commented Jan 27, 2020

@roywei could you cherry-pick this to 1.6.x?

roywei added a commit to roywei/incubator-mxnet that referenced this pull request Jan 28, 2020
@eric-haibin-lin @roywei
[LICENSE] fix cpp predcit license (apache#17377)
b13f19b 
* fix cpp predcit license

* add white list (apache#210)

* fix white list (apache#211)

Co-authored-by: Lai Wei <[email protected]>
@roywei roywei mentioned this pull request Jan 28, 2020
Merged
szha pushed a commit that referenced this pull request Jan 29, 2020
@roywei @eric-haibin-lin
Cherry pick license fixes for 1.6 (#17460)
6eec9da 
* Update NOTICE to fix copyright years (#17330)

* Update LICENSE for fonts (#17365)

* license np_einsum file under bsd (#17367)

* license under bsd

* fix rat exclude

* remove unused file with license issue (#17371)

* [LICENSE] fix cpp predcit license (#17377)

* fix cpp predcit license

* add white list (#210)

* fix white list (#211)

Co-authored-by: Lai Wei <[email protected]>

* add disclaimer (#17428)

* add disclaimer

* add white list

* fix exclude

* remove disclaimer

* update tools/pip

Co-authored-by: Haibin Lin <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@roywei roywei roywei approved these changes

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eric-haibin-lin @ChaiBapchya @skylook @roywei