This repository was archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[NumPy]Set numpy default dtype #17283
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haojin2
reviewed
Jan 13, 2020
haojin2
reviewed
Jan 13, 2020
haojin2
reviewed
Jan 16, 2020
43be279 to
8d10502
Compare
995d347 to
e21d8f2
Compare
49ca61c to
a363223
Compare
haojin2
reviewed
Mar 3, 2020
haojin2
reviewed
Apr 9, 2020
a363223 to
71a5ef7
Compare
Contributor
Author
|
@mxnet-bot run ci [windows-cpu] |
|
Jenkins CI successfully triggered : [windows-cpu] |
Contributor
Author
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
Contributor
Author
|
@mxnet-bot run ci [windows-cpu] |
|
Jenkins CI successfully triggered : [windows-cpu] |
Contributor
Author
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
fix sanity error fix sanity error
fix sanity error fix rebase error
585815b to
838d7b8
Compare
yzhliu
approved these changes
Apr 28, 2020
sxjscience
added a commit
to sxjscience/mxnet
that referenced
this pull request
Apr 29, 2020
This reverts commit 5c525c9.
sxjscience
added a commit
that referenced
this pull request
Apr 30, 2020
JiangZhaoh
added a commit
to JiangZhaoh/incubator-mxnet
that referenced
this pull request
May 6, 2020
JiangZhaoh
added a commit
to JiangZhaoh/incubator-mxnet
that referenced
this pull request
May 12, 2020
yzhliu
pushed a commit
that referenced
this pull request
May 19, 2020
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
* draft 1 Preliminary completion fix rebase mistake * add new change * use global flag & fix part of CI error * fix CI error * modify docs * rebase * consistent with FFI * ones/full ffi * arange ffi * identity ffi * depart set_np_default_dtype from set_np to test CI fix sanity error fix sanity error * test CI * fix CI error : use InitNumpyType instead of InitType / remove full ffi fix sanity error fix rebase error * try to pass CI * set the second output's dtype of normal to be float32 * modify ffi op * update & rebase * test windows CI * comment test when platform is windows * resolve comment * add to set_np
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
This reverts commit 5c525c9.
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
* apply apache#17283 * fix issue apache#18060 * fix error * remove redundant code * fix CI error * replace Flase to False * add 'dtype=False' to set_np() * fix doc * default 'arange' default np dtype as int64
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new feature to be consistent with numpy default type.
For example, in original, default type only support 32 bit storage dtype such as float32 (or int32 in some special op). However, with this new feature, user can set 64 bit storage type as default dtype, such as float64 (int64 for some special op).
e.g.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments