Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@larroy
Copy link
Contributor

@larroy larroy commented Jan 2, 2020

Description

Update windows build from source documentation with automated scripts.

As part of fixing the windows CI AMI, the scripts to setup the build environment are referenced from the documentation for ease of use.

With this PR seting up the environment in windows consists of executing just a powershell script

.\setup.ps1

Together with ci/build_windows.py this makes 2 commands to build MXNet in a clean windows install.

Before the process to setup the required environment required tons of manual and error prone install and steps.

Chance Bair is also co-author of the installation script.

Verified that the updated instructions lead to a working MXNet build:

PS C:\Users\Administrator\incubator-mxnet> C:\Python37\python
Python 3.7.0 (v3.7.0:1bf9cc5093, Jun 27 2018, 04:59:51) [MSC v.1914 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import mxnet as mx
>>> a = mx.nd.array((3,3))
>>> a

[3. 3.]
<NDArray 2 @cpu(0)>
>>>

@aaronmarkham @leezu @Chancebair

@larroy larroy changed the title Update documentation with automated windows environment scripts [DOC] Update documentation with automated windows environment scripts Jan 2, 2020
@larroy
Copy link
Contributor Author

larroy commented Jan 2, 2020

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jan 2, 2020
@larroy larroy requested a review from marcoabreu as a code owner January 3, 2020 01:48
@larroy larroy changed the title [DOC] Update documentation with automated windows environment scripts Windows automation improvements Jan 3, 2020
@larroy larroy changed the title Windows automation improvements Windows dev environment configuration, update install instructions from source in the docs. Jan 3, 2020
@leezu leezu requested a review from yajiedesign January 3, 2020 08:04
@larroy
Copy link
Contributor Author

larroy commented Jan 7, 2020

😴

Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm besides nits.

I'd prefer if someone else could review the docs changes

@@ -0,0 +1,4 @@
psutil
boto3
python-jenkins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added it, is it in the slave scripts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yeah it's used as part of the Autoconnect script. But since you are recommending this for users to install, it seems a bit out of place. We should handle infrastructure and MXNet related things separately if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove it in the future, it doesn't hurt there now, and I don't want additional scripts as of now. I don't think this is a big concern, even though you are right.

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues...

@larroy larroy changed the title Windows dev environment configuration, update install instructions from source in the docs. [WIP] Windows dev environment configuration, update install instructions from source in the docs. Feb 24, 2020
@larroy larroy closed this Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants