This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add mkldnn_version.h to pip package #14899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@szha @pengzhao-intel @TaoLv Please help review. |
szha
approved these changes
May 6, 2019
szha
reviewed
May 6, 2019
TaoLv
approved these changes
May 7, 2019
Member
|
Thank you for the fix @yuxihu. Merging now. |
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 14, 2019
* add mkldnn_version.h to pip package * add headers from build/install/include folder
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* add mkldnn_version.h to pip package * add headers from build/install/include folder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per changes in #13668, we generate a new header file
mkldnn_version.hduring MXNet compilation based on the template file mkldnn_version.h.in. This dynamically generated header file needs to be added to the MXNet pip package to prevent compilation failure for building Horovod with MKLDNN enabled MXNet pip package.