Feature/mkldnn static #13628
Feature/mkldnn static #13628
Conversation
This reverts commit a3eca5f.
| ifneq ($(UNAME_S), Windows) | ||
| LIB_DEP += $(MKLDNNROOT)/lib/libmkldnn.a | ||
| else | ||
| LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}' |
There was a problem hiding this comment.
VS compiler doesn't know those flags. Do we support VS build with Makefile?
There was a problem hiding this comment.
Nope, windows uses cmake
There was a problem hiding this comment.
@marcoabreu Thanks for explanation. This is as I expected. So we don't need to consider Windows build in Makefile.
There was a problem hiding this comment.
Why don't remove LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}'? It doesn't work on Windows.
There was a problem hiding this comment.
The line was there before. I am not trying to change builds on windows.
There was a problem hiding this comment.
This line is used for Linux MKLDNN dynamic build. Then why not remove it? As @marcoabreu said, Windows build doesn't use Makefile.
This reverts commit 5bcf2bd.
5 participants
currently MKLDNN is dynamically linked to mxnet. This can cause some issues if another version of mkldnn is present on the host machine and mxnet links to the host version. This change statically builds mkldnn into mxnet to handle version issues on linux/mac but keeps it dynamically linked on windows.
removed test_mkldnn_install.py from test as well since it tests if mkldnn is dynamically linked on linux (which it is no longer is)
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments