This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file" #13558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoLv
requested review from
anirudh2290,
gigasquid,
nswamy,
szha and
yzhliu
as code owners
Member
Author
|
Please do not merge. Don't know why it reverts so many commits by just clicking the revert button in #13478. |
Contributor
|
Don't look at the commits but just the files changes. GitHub sometimes bugs out with the commit list for reverts. Alternatively, you can do a revert using the console. |
marcoabreu
approved these changes
Dec 6, 2018
Contributor
marcoabreu
left a comment
marcoabreu
left a comment
There was a problem hiding this comment.
On a first glance, it looks good to me. Please double check and then feel free to merge
Member
Author
|
Thank you @marcoabreu . A little scared by Github. The code change looks good to me. So I think it's safe to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13478
#13478 brought in some non-related code change including those changes in #13503 and would cause build issue of MXNet.
@srochel Feel free to submit new PR for your changes.