This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[Clojure] Correct the versions in the README so they correspond to the latest maven.org release #13507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lanking520
approved these changes
Dec 4, 2018
Member
lanking520
left a comment
lanking520
left a comment
There was a problem hiding this comment.
Agree for now. But will you need to do this again if we release 1.4.0?
Member
Author
|
@lanking520 good point - I think it might be beneficial to change it to more general language so we don't need to update it every release |
Member
Author
|
Also going to wait until #13478 is merged first |
kohr-h
reviewed
Dec 6, 2018
Contributor
kohr-h
left a comment
kohr-h
left a comment
There was a problem hiding this comment.
I got a few comments, but overall this totally makes sense.
Member
Author
|
Thanks so much @kohr-h for your review and comments. Much appreciated 💯 . I will incorporate your feedback shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the last big version update, the README for the Clojure package had the incorrect versions put in.
After some conversations with people managing the release updates, it seems like it would be better to have it version independent so that the README would not have to be updated with every release.
Instructions were also added about using the Scala nightly snapshots instead of having to build master.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.