Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Dec 1, 2018

Description

Fixes #13446 flaky test test_random:test_randint_generator
Uses the PR #13543 to get rid of the fix seed and make the test robust

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

@ChaiBapchya ChaiBapchya requested a review from szha as a code owner December 1, 2018 00:43
@vandanavk
Copy link
Contributor

@mxnet-label-bot add [Flaky, pr-awaiting-review]

@marcoabreu marcoabreu added Flaky pr-awaiting-review PR is waiting for code review labels Dec 1, 2018
@anirudh2290
Copy link
Member

Can you run this test repeatedly 1k times with different seeds to check flakiness.

@ChaiBapchya
Copy link
Contributor Author

@anirudh2290 Have tried it 1000 times

MXNET_TEST_COUNT=1000 python -m nose -v --nocapture tests/python/unittest/test_random.py:test_randint_generator

Python3 CPU Linux

@anirudh2290 anirudh2290 merged commit 0011ab2 into apache:master Dec 7, 2018
@ChaiBapchya ChaiBapchya deleted the fix_flaky_randint_generator branch July 29, 2019 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Flaky pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky test: test_random.test_randint_generator

7 participants