Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@lebeg
Copy link
Contributor

@lebeg lebeg commented Nov 12, 2018

…v1.3.x) (#13121)"

This reverts commit d0b83d4.

Description

Tests started to fail after this commit.

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/v1.3.x/82/pipeline

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@lebeg lebeg requested a review from szha as a code owner November 12, 2018 18:22
@harshp8l
Copy link
Contributor

@mxnet-label-bot add [pr-work-in-progress]

@marcoabreu marcoabreu added the pr-work-in-progress PR is still work in progress label Nov 12, 2018
@lebeg lebeg changed the title (WIP) Revert "Set correct update on kvstore flag in dist_device_sync mode (… Revert "Set correct update on kvstore flag in dist_device_sync mode (… Nov 12, 2018
@lebeg
Copy link
Contributor Author

lebeg commented Nov 12, 2018

dist-kvstore tests CPU passed, PR good to go

@lebeg
Copy link
Contributor Author

lebeg commented Nov 12, 2018

@nswamy

@lebeg
Copy link
Contributor Author

lebeg commented Nov 12, 2018

@mxnet-label-bot remove [pr-work-in-progress]

@marcoabreu marcoabreu removed the pr-work-in-progress PR is still work in progress label Nov 12, 2018
@nswamy nswamy merged commit 0cb2ad6 into apache:v1.3.x Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants