Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Nov 6, 2018

Description

port #13034 to release branch

add sample_like operators for the following random operators:

uniform
normal
gamma
exponential
poisson
negative_binomial
generalized_negative_binomial

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin changed the title sample_like operators (#13034) sample_like operators (#13034) v1.3.x Nov 6, 2018
@anirudhacharya
Copy link
Member

@mxnet-label-bot [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Nov 6, 2018
@lebeg
Copy link
Contributor

lebeg commented Nov 6, 2018

As stated in the @dev list, I would be rather opposed to have it in the patch release.

@szha szha merged commit 936acb8 into apache:v1.3.x Nov 7, 2018
@eric-haibin-lin eric-haibin-lin deleted the random_like branch December 12, 2019 00:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants