This repository was archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[MXNET-12627] Fixed param coercion of clojure executor/forward #12630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey, thanks for your contribution! Would you mind adding a test please? |
Member
Contributor
Author
|
sure, i'll update it and add the tests. |
Contributor
Author
|
oops! will reopen after the update |
Contributor
|
Feel free to just leave the PR open |
Contributor
|
Thanks for making the clojure binding better! @paroda |
Contributor
Author
|
updated with tests |
gigasquid
approved these changes
Sep 21, 2018
Member
gigasquid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the improvement 😄
Member
|
When the CI tests pass. It's good to merge - Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with clojure package (issue #12627)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
minor bugfix