This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-690] Add tests for initializers in R #12360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudhacharya
force-pushed
the
initTest
branch
from
974473d to
3503d37
Compare
anirudhacharya
changed the title
hetong007
suggested changes
Aug 28, 2018
|
|
||
| testthat("mx.init.internal.default", { | ||
| sample_bias <- mxnet:::mx.init.internal.default("X_bias", c(5, 10, 100), | ||
| ctx = mx.ctx.default()) |
| expect_equal(typeof(xavier_init), 'closure') | ||
|
|
||
| # default parameters | ||
| shape <- c(2, 3, 324, 324) |
Contributor
There was a problem hiding this comment.
Is there a reason to pick 324?
Member
Author
There was a problem hiding this comment.
no particular reason, I just did not want to pick a number too low that the test becomes flaky or too high that the test takes very long to execute. It was quite random
Contributor
There was a problem hiding this comment.
OK. As long as it works.
Member
Author
|
@hetong007 ran |
hetong007
approved these changes
Aug 28, 2018
Contributor
|
LGTM |
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
* Add tests for intializer * lint and indent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for uniform, normal and Xavier initializers.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Comments