This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Explain a bit more details for Scala NDCollector's Experimental #12348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
approved these changes
Aug 25, 2018
Member
lanking520
left a comment
lanking520
left a comment
There was a problem hiding this comment.
Please add some lines in the comment field briefly explain the component added.
LGTM
nswamy
approved these changes
Aug 25, 2018
yzhliu
force-pushed
the
update-experimental-reason
branch
from
f8fcee4 to
2713a21
Compare
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain why NDCollector.withScope is marked as Experimental.
+Also Experimental can mean the API might be removed.
Why is this patch required?
To let users know it is not a functionality problem to mark it as Experimental.
How have you tested this patch?
add comments. no need to test.