Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@Roshrini
Copy link
Member

@Roshrini Roshrini commented Aug 24, 2018

Description

@szha

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable

* Disable a test that's taking longer than 10 minutes with the Python 2
  interpreter in the Straight Dope Nightly.
@szha szha merged commit d2495d1 into apache:master Aug 24, 2018
@Roshrini Roshrini deleted the nightly-test branch August 24, 2018 23:31
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
…pache#12339)

* Disable a test that's taking longer than 10 minutes with the Python 2
  interpreter in the Straight Dope Nightly.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants