Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@KellenSunderland
Copy link
Contributor

@KellenSunderland KellenSunderland commented Aug 23, 2018

Description

Clang 6 has now been officially released (as of July 5th, 2018). It will be a very popular compiler in the future, and we should adopt it in CI to try and guarantee the maximum amount of forwards compatibility possible for releases.

http://releases.llvm.org/6.0.1/tools/clang/docs/ReleaseNotes.html

Clang 6 contains better tooling, more openmp support and improved sanitizers which may be interesting for the MXNet project.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@marcoabreu marcoabreu merged commit 72efe41 into apache:master Aug 23, 2018
Roshrini pushed a commit to Roshrini/mxnet that referenced this pull request Aug 24, 2018
@Roshrini Roshrini mentioned this pull request Aug 24, 2018
3 tasks
szha pushed a commit that referenced this pull request Aug 24, 2018
* Fix a bug in where op with 1-D input (#12325)

* Fix a bug in where op with 1-D input

* Add unit test

* [MXNET-849] - Enable armv7 with pinned docker images. (#12272)

* Revert "Temporarily disable ARMv7 builds (#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <[email protected]>

* [MXNET-855] Update clang to version 6 (#12305)
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants