-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Tighten up PyLint directives #12278
Tighten up PyLint directives #12278
Conversation
marcoabreu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm besides two minor slips.
Thanks for improving our quality!
| from ..base import mx_uint, check_call, _LIB, py_str, _init_op_module, _Null # pylint: disable=unused-import | ||
|
|
||
|
|
||
| # pylint: disable=too-many-locals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obsolete due to global disable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defies explanation but these are actually required or the tests fail.
| raise TypeError('Only accept list of NDArrays or dict of str to NDArray') | ||
| return c_array(NDArrayHandle, arg_handles), arg_arrays | ||
|
|
||
| # pylint: disable=too-many-locals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obsolete due to global disable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defies explanation but these are actually required or the tests fail.
|
Closing in favor of #12322 |
Description
Remove PyLint disable directives that the codebase is not violating. This tightens up the linting of future proposed changes. Also looked through PyLint issues that were only being flagged once in the code base to see if small changes code make the code compliant. Fixed via code changes:
@vandanavk
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments