Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 17, 2018

Python 2 has low tolerance for Unicode characters in source files without proper encoding specified. This PR removes the comment line that contains the Unicode character

Fix suggested by the discussion at #12231 (comment)

Probably a better way to proceed than #12231

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Python 2 has low tolerance for Unicode characters in source files without proper encoding specified.  This PR removes the comment line that contains the Unicode character

Fix suggested by the discussion at #12231 (comment)

Probably a better way to proceed than #12231
@marcoabreu
Copy link
Contributor

Thank you and sorry for the revert. Please feel free to re-add the functionality you added. We just reverted the PR to ensure we are back in a state that we know is working properly. We also made some changes around python 2 and 3 and thus we wanted to rule out any errors related to these switches.

It seems strange that it is necessary to remove that comment. Do you think you would be able to add a check to our linter that would detect cases like this before we encounter them during runtime? That would be SUPER helpful :)

In general, thanks a lot for improving the usability of mxnet! It is very appreciated.

@cclauss cclauss closed this Aug 17, 2018
@cclauss cclauss deleted the patch-1 branch August 17, 2018 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants