Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Revert "[MXNET-696] Define cmp() in Python 3 for line 222 (#12191)" #12231

Merged
marcoabreu merged 1 commit into from
Aug 17, 2018
Merged

Revert "[MXNET-696] Define cmp() in Python 3 for line 222 (#12191)" #12231

marcoabreu merged 1 commit into from
Aug 17, 2018

Conversation

@vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Aug 17, 2018

This reverts commit 54ed3e5.

Description

Raising PR instead of #12229. This reverts only 1 commit.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@piyushghai piyushghai mentioned this pull request Aug 17, 2018
Closed
@vandanavk
Copy link
Contributor Author

vandanavk commented Aug 17, 2018

@marcoabreu @haojin2 @piyushghai @cclauss

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Aug 17, 2018
@cclauss
Copy link
Contributor

cclauss commented Aug 17, 2018

What problem did #12191 cause?

@marcoabreu
Copy link
Contributor

marcoabreu commented Aug 17, 2018

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-backwards-compatibility-checker/detail/restricted-backwards-compatibility-checker/27/pipeline

 python model_backwards_compat_train.py

Traceback (most recent call last):

  File "model_backwards_compat_train.py", line 20, in <module>

    from common import *

  File "/work/mxnet/tests/nightly/model_backwards_compatibility_check/common.py", line 35

SyntaxError: Non-ASCII character '\xc2' in file /work/mxnet/tests/nightly/model_backwards_compatibility_check/common.py on line 35, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

build.py: 2018-08-17 20:45:17,059 Running of command in container failed (1):

@cclauss cclauss mentioned this pull request Aug 17, 2018
Closed
7 tasks
@marcoabreu marcoabreu merged commit 24e42a0 into apache:master Aug 17, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@vandanavk @marcoabreu
Revert "[MXNET-696] Define cmp() in Python 3 for line 222 (apache#12191…
726bd60 
…)" (apache#12231)

This reverts commit 54ed3e5.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@marcoabreu marcoabreu marcoabreu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vandanavk @cclauss @marcoabreu