Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Revert "[MXNET-696] Define cmp() in Python 3 for line 222" #12229

Closed
marcoabreu wants to merge 11 commits into from
Closed

Revert "[MXNET-696] Define cmp() in Python 3 for line 222" #12229

marcoabreu wants to merge 11 commits into from

Conversation

@marcoabreu
Copy link
Contributor

@marcoabreu marcoabreu commented Aug 17, 2018

Reverts #12191

We reverted the underlying change and thus this PR is not necessary (and is no longer compatible)

@marcoabreu
Revert "Add test to check that binded is not set when exception thrown (
526f613 
#12167)"

This reverts commit f737cac.
@marcoabreu
Revert "Fix a bug in CachedOP. (#12184)"
f52fb56 
This reverts commit cd9f9c8.
@marcoabreu
Revert "[MXNET-791] Pick with negative indices (#12090)"
1dea56b 
This reverts commit 633bef3.
@marcoabreu
Revert "Revert "CI scripts refinements. Separate Py2 and Py3 installs…
40edbe7 
… cripts. Fix perms. (#12125)" (#12223)"

This reverts commit 2ff1837.
@marcoabreu
Revert "Disable flaky test: test_operator_gpu.test_convolution_groupi…
c055d08 
…ng (#12220)"

This reverts commit fa18f51.
@marcoabreu
Revert "[MXNET-689] add DataDesc type for the Scala Package (#11844)"
1ac4f42 
This reverts commit abbe283.
@marcoabreu
Revert "fix flasky unittest for deformable psroi pooling (#12178)"
9569e67 
This reverts commit 2b4d512.
@marcoabreu
Revert "Update README.md (#12208)"
6ab2519 
This reverts commit 599ffe4.
@marcoabreu
Revert "Fix typo. (#12211)"
034b6f8 
This reverts commit 38bcb88.
@marcoabreu
Revert "documentation fix (#12212)"
ead8b8d 
This reverts commit b793768.
@marcoabreu
Revert "[MXNET-696] Define cmp() in Python 3 for line 222 (#12191)"
2625d33 
This reverts commit 54ed3e5.
@marcoabreu
Copy link
Contributor Author

marcoabreu commented Aug 17, 2018

@piyushghai @cclaus fyi

@haojin2
Copy link
Contributor

haojin2 commented Aug 17, 2018 •
edited
Loading

Just wonder why are you also reverting a bunch of other un-related changes? (I'm taking a look at the commits part)

@marcoabreu
Copy link
Contributor Author

marcoabreu commented Aug 17, 2018 •
edited
Loading

I just pressed the revert button, I don't know what GitHub is doing there ._.

Please have a look at the diff, it looks good to me

@marcoabreu
Copy link
Contributor Author

marcoabreu commented Aug 17, 2018

I'm only on my phone right now, so I can't make a revert with the command line. In the end, the commits will be squashed so it should not make much of a difference as long as the diff is good

@haojin2
Copy link
Contributor

haojin2 commented Aug 17, 2018

@marcoabreu Could you do a double-check please? Cause one of the commits on the list shows that it's reverting an important fix for the next release.

@piyushghai
Copy link
Contributor

piyushghai commented Aug 17, 2018

The file diff looks good as it was the only change in that PR.
Not sure, why the other commits are showing up here.

@marcoabreu
Copy link
Contributor Author

marcoabreu commented Aug 17, 2018

If you click on the commits in this PR, you will see that they are all empty except the last one. Please feel free to make a proper revert with only one commit and open a new PR. I'm sorry that I can't do it myself right now.

@vandanavk vandanavk mentioned this pull request Aug 17, 2018
Merged
7 tasks
@piyushghai
Copy link
Contributor

piyushghai commented Aug 17, 2018

Check PR #12231 .
That includes just one commit required.
@marcoabreu Feel free to close this one.

@marcoabreu
Copy link
Contributor Author

marcoabreu commented Aug 17, 2018

Thank you!

@marcoabreu marcoabreu closed this Aug 17, 2018
@szha szha deleted the revert-12191-patch-2 branch August 24, 2018 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcoabreu @haojin2 @piyushghai