Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@zheng-da
Copy link
Contributor

Description

This is to fix a bug in #10914

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@szha szha merged commit ce57b58 into apache:master May 13, 2018
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request May 29, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da added a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 8, 2018
zheng-da added a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 11, 2018
zheng-da added a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 13, 2018
zheng-da added a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@zheng-da zheng-da deleted the fix_softmax_act branch July 5, 2018 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants