Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

MXNet 0.11.0 Release Feedback: Source Headers and License Files #7749

@mbaijal

Description

@mbaijal

As discussed in various email threads - Voting thread, Source Headers and ICLAs vs Contributors

1. Headers
a) "The source headers should be reverted in any areas where not all contributors to that file have signed ICLAs, otherwise we need some kind of agreement they are OK with moving to NOTICE file (which is how this has been handled in the past)"
b) While a number of file (around 50 odd) do have "Copyright (c) 2016 by Contributors” they don’t have a full Apache licensed header please fix this in the next release. More files exist with other years and without the correct header.

2. License Files
a) Missing - BSD license for this file [4]
b) Missing - MIT licensed JQuery and Sizzle.js [5]
c) Missing - This BSD licensed file [6]
d) Missing - Boost Software licensed file [7]
e) Missing - This BSD licensed files [8][9]
f) This license file may be a little misleading [1] where its apache license but also claims “All rights reserved”. I notice this in a number of other places as well.
g) A number of Apache licenses have incorrect appendixes with the copyright line filled in e.g. [2]
h) This file may incorrect have an ASF header on it [3]

3. Files referred above can be found as follows -

[1] ./src/operator/contrib/ctc_include/LICENSE
[2]../dlpack/LICENSE
[3] ./example/image-classification/predict-cpp/image-classification-predict.cc
[4] ./docs/_static/searchtools_custom.js
[5] ./docs/_static/jquery-1.11.1.js
[6] ./cub/test/mersenne.h
[7] ./cmake/Modules/FindJeMalloc.cmake
[8] ./dmlc-core/cmake/Modules/FindCrypto.cmake
[9] ./nnvm/dmlc-core/cmake/Modules/FindCrypto.cmake

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions