Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Failing test with numpy upgrade - test_np_delete() #20880

@josephevans

Description

@josephevans

When upgrading numpy to 1.19.0 or higher in the MXNet CI, we encounter test failures with test_np_delete():

======================================================================
ERROR: test_numpy_op.test_np_delete
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/mxnet/venv/lib/python3.8/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/ubuntu/mxnet/tests/python/unittest/common.py", line 218, in test_new
    orig_test(*args, **kwargs)
  File "/home/ubuntu/mxnet/python/mxnet/util.py", line 297, in _with_np_shape
    return func(*args, **kwargs)
  File "/home/ubuntu/mxnet/python/mxnet/util.py", line 481, in _with_np_array
    return func(*args, **kwargs)
  File "/home/ubuntu/mxnet/tests/python/unittest/test_numpy_op.py", line 3636, in test_np_delete
    expected_ret = _np.delete(a.asnumpy(), obj_onp, axis=axis)
  File "<__array_function__ internals>", line 5, in delete
  File "/home/ubuntu/mxnet/venv/lib/python3.8/site-packages/numpy/lib/function_base.py", line 4406, in delete
    keep[obj,] = False
IndexError: index 0 is out of bounds for axis 0 with size 0

When running the test on numpy==1.18.5, the test passes but indicates a warning:

FutureWarning: in the future negative indices will not be ignored by `numpy.delete`.

The functionality changed for numpy.delete() in this commit, where previously out-of-bounds indices were ignored.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions