[MSHARED-1128] Update documentation with new execute method #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
added
the
documentation
kwin
requested changes
Sep 20, 2022
slawekjaranowski
force-pushed
the
MSHARED-1128-doc
branch
from
b351fa2 to
bc00c95
Compare
Member
Author
|
suggestions applied, please next round of review |
michael-o
approved these changes
Sep 21, 2022
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
One nit, but the rest looks good.
Co-authored-by: Konrad Windszus <[email protected]>
slawekjaranowski
force-pushed
the
MSHARED-1128-doc
branch
from
bc00c95 to
a6cb051
Compare
gnodet
requested changes
Sep 21, 2022
gnodet
requested changes
Sep 21, 2022
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Btw, I've seen a few other deprecated methods which are not flagged as @Deprecated with a proper annotation (just the @deprecated javadoc tag):
resetStreams()displayStreamBuffers()setDebug()setMavenDebug()
It would be nice to add the annotation on those too !
Member
Author
|
@gnodet thanks - you are right - I will add all missing annotation in separate PR. |
gnodet
approved these changes
Sep 21, 2022
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Approved, but please add @Deprecated annotations in a separate PR.
|
Resolve #155 |
1 similar comment
|
Resolve #155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.