[MSHARED-1128] Introduce execute method and deprecate executeGoal(s) #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Sep 11, 2022
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
A few comments left. What I have noticed is that both system properties and env vars are read-write and can be retrieved. What is your opinion on this, should they be read-only or not getter at all?
slawekjaranowski
force-pushed
the
MSHARED-1128
branch
from
7292a27 to
ca5d631
Compare
michael-o
approved these changes
Sep 12, 2022
|
Resolve #155 |
1 similar comment
|
Resolve #155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.