Skip to content

[MSHARED-1129] Prepare for replace CLI options with CLI args #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slawekjaranowski merged 1 commit into from
Sep 11, 2022
Merged

[MSHARED-1129] Prepare for replace CLI options with CLI args #42

slawekjaranowski merged 1 commit into from
Sep 11, 2022

Conversation

@slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented Sep 10, 2022

  • add new methods
  • deprecate old

michael-o
michael-o requested changes Sep 10, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few inconsistency issues:

  • getCliArgs() as read-only is missing
  • internal fields end with ...Arguments, but the methods with ...Args. Should be consistent. Either or.

@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Sep 10, 2022

I see a few inconsistency issues:

  • getCliArgs() as read-only is missing

There is no getCliArgs/getCliArguments methods - arguments are read only, there are only add methods

  • internal fields end with ...Arguments, but the methods with ...Args. Should be consistent. Either or.

renamed

michael-o
michael-o reviewed Sep 10, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect. A few open questions.

michael-o
michael-o approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@slawekjaranowski slawekjaranowski merged commit bbc5aee into master Sep 11, 2022
@slawekjaranowski slawekjaranowski deleted the MSHARED-1129 branch September 11, 2022 12:26
@slawekjaranowski slawekjaranowski added the deprecated Pull requests that deprecate features label Sep 19, 2022
@jira-importer
Copy link

jira-importer commented Jun 9, 2025

Resolve #156

1 similar comment
@jira-importer
Copy link

jira-importer commented Jun 9, 2025

Resolve #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnodet gnodet gnodet left review comments

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

deprecated Pull requests that deprecate features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slawekjaranowski @jira-importer @gnodet @michael-o