Skip to content

[MSHARED-1010] Allow to set dedicated Maven home directory #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slawekjaranowski merged 1 commit into from
Mar 8, 2022
Merged

[MSHARED-1010] Allow to set dedicated Maven home directory #4

slawekjaranowski merged 1 commit into from
Mar 8, 2022

Conversation

@kwin
Copy link
Member

@kwin kwin commented Jan 3, 2022

No description provided.

@kwin kwin force-pushed the feature/MSHARED-1010 branch from d609e64 to 73d7d70 Compare January 3, 2022 08:52
@kwin kwin force-pushed the feature/MSHARED-1010 branch from 73d7d70 to ec18db8 Compare January 3, 2022 08:56
@kwin
Copy link
Member Author

kwin commented Jan 6, 2022

@michael-o or @rfscholte : Can you have a look?

michael-o
michael-o reviewed Jan 6, 2022
View reviewed changes
.gitignore
.settings/
.svn/
bin/
/bin/
Copy link
Member

@michael-o michael-o Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Member Author

@kwin kwin Jan 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bin folder is included in the test resources as this is part of the layout below maven home (https://github.com/apache/maven-verifier/pull/4/files#diff-770f62c0c49568f6bdd2aaabe732e084a54c6646756e823382668d9b888563cfR1)! The intent here is to only exclude compiled classes which will only ever end up in the to-level directory /bin (if at all)!

michael-o
michael-o reviewed Jan 6, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change confuses me, it seems that it contains unrelated changes. If so, move them to a separate preceeding PR.

@kwin
Copy link
Member Author

kwin commented Jan 6, 2022

it seems that it contains unrelated changes.

which changes are you referring to exactly?

michael-o
michael-o reviewed Jan 6, 2022
View reviewed changes
michael-o
michael-o reviewed Jan 6, 2022
View reviewed changes
michael-o
michael-o reviewed Jan 6, 2022
View reviewed changes
michael-o
michael-o reviewed Jan 6, 2022
View reviewed changes
@michael-o
Copy link
Member

michael-o commented Jan 6, 2022

it seems that it contains unrelated changes.

which changes are you referring to exactly?

I am fine with your explanations.

@slawekjaranowski slawekjaranowski merged commit 5d1a53a into apache:master Mar 8, 2022
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Mar 15, 2022
@jira-importer
Copy link

jira-importer commented Jun 9, 2025

Resolve #149

3 similar comments
@jira-importer
Copy link

jira-importer commented Jun 9, 2025

Resolve #149

@jira-importer
Copy link

jira-importer commented Jun 9, 2025

Resolve #149

@jira-importer
Copy link

jira-importer commented Jun 9, 2025

Resolve #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o left review comments

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kwin @michael-o @jira-importer @slawekjaranowski