[MSHARED-871] add basic documentation #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slachiewicz
approved these changes
Mar 11, 2022
slawekjaranowski
requested changes
Mar 11, 2022
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
- do we need some of special dependency for project in order to use embedded mode?
- example of setting mave.home propery by failsafe will be useful, like
<plugin>
<artifactId>maven-failsafe-plugin</artifactId>
<configuration>
<systemPropertyVariables>
<maven.home>${maven.home}</maven.home>
</systemPropertyVariables>
</configuration>
</plugin>
kwin
force-pushed
the
feature/MSHARED-871-initial-documentation
branch
from
f71cf5c to
6ae0fdb
Compare
Member
|
pleas also add menu item under |
kwin
force-pushed
the
feature/MSHARED-871-initial-documentation
branch
from
6ae0fdb to
fe83a42
Compare
slawekjaranowski
approved these changes
Mar 12, 2022
kwin
force-pushed
the
feature/MSHARED-871-initial-documentation
branch
2 times, most recently
from
2da6bdf to
9925458
Compare
hboutemy
approved these changes
Mar 13, 2022
Member
hboutemy
left a comment
hboutemy
left a comment
There was a problem hiding this comment.
nice work done, thank you
can be merged now or with the few little enhancements proposed
kwin
force-pushed
the
feature/MSHARED-871-initial-documentation
branch
from
9925458 to
1d1d15c
Compare
slawekjaranowski
added
the
documentation
|
Resolve #145 |
1 similar comment
|
Resolve #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.