[MSHARED-1014] Make Commandline.addSystemEnvironment public and deprecated

slawekjaranowski · slawekjaranowski · commit 462bd1121b7a · 2023-04-21T21:23:45.000+02:00
MavenInvoker still use it.
diff --git a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
@@ -183,8 +183,13 @@ public void addEnvironment(String name, String value) {
 
     /**
      * Add system environment variables.
+     *
+     * @deprecated please use {@link #setShellEnvironmentInherited(boolean)}
      */
-    private void addSystemEnvironment() {
+    @Deprecated
+    public void addSystemEnvironment() {}
+
+    private void copySystemEnvironment() {
         Properties systemEnvVars = CommandLineUtils.getSystemEnvVars();
 
         for (Object o : systemEnvVars.keySet()) {
@@ -202,7 +207,7 @@ private void addSystemEnvironment() {
      */
     public String[] getEnvironmentVariables() {
         if (isShellEnvironmentInherited()) {
-            addSystemEnvironment();
+            copySystemEnvironment();
         }
 
         List<String> environmentVars = new ArrayList<>();
