[MNG-7729] deprecate questionable IsEmpty/IsNotEmpty methods (#136)

elharo · web-flow · commit 259b796b2ae9 · 2023-04-28T11:06:13.000-04:00
* deprecate questionable utility methods
diff --git a/src/main/java/org/apache/maven/shared/utils/xml/Xpp3Dom.java b/src/main/java/org/apache/maven/shared/utils/xml/Xpp3Dom.java
@@ -354,17 +354,27 @@ private PrettyPrintXMLWriter getPrettyPrintXMLWriter(StringWriter writer) {
     }
 
     /**
-     * @param str The string to be checked.
-     * @return true if the string is not empty (length &gt; 0) and not <code>null</code>.
+     * Warning: this is not the reverse of {@link #isEmpty}.
+     * Whitespace only strings are both empty and not empty.
+     *
+     * @param str the string to be checked
+     * @return true if the string is not empty (length &gt; 0) and not <code>null</code>
+     * @deprecated use <code>str != null &amp;&amp; !str.isEmpty()</code>
      */
+    @Deprecated
     public static boolean isNotEmpty(String str) {
         return str != null && str.length() > 0;
     }
 
     /**
-     * @param str The string to be checked.
-     * @return true if the string is empty or <code>null</code>.
+     * Warning: this is not the reverse of {@link #isNotEmpty}.
+     * Whitespace only strings are both empty and not empty.
+     *
+     * @param str the string to be checked
+     * @return true if the string only contains whitespace or is <code>null</code>
+     * @deprecated use <code>str == null || str.trim().isEmpty()</code>
      */
+    @Deprecated
     public static boolean isEmpty(String str) {
         return str == null || str.trim().length() == 0;
     }
