Skip to content

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Oct 1, 2021

Ground work for https://issues.apache.org/jira/browse/MNG-7266.

Upgrading to maven 3.1.1 is not really possible as the ProjectArtifactFactory has been introduced in 3.2.x branch and is required in order to get rid of the deprecated MavenProject.createArtifacts(xxx) method.

The ModelInheritanceAssembler and ModelUtils have been imported from maven-compat in order to not depend on that deprecated jar.

@cstamas
Copy link
Member

cstamas commented Oct 1, 2021

Personally I see this as a proof that our baseline of 3.1.1 is simply wrong/broken idea.

I am +1 on this change, but we should reconcile what is the proper baseline (I am in "the higher the better" ballpark). We should go 3.6 as baseline (and even then, we cover 3.6.x and 3.8.x that is still a huge time-span).

@slachiewicz
Copy link
Member

To me, 3.3.9 sounds like reasonable minimum for next year.

@gnodet
Copy link
Contributor Author

gnodet commented Oct 2, 2021

Personally I see this as a proof that our baseline of 3.1.1 is simply wrong/broken idea.

I am +1 on this change, but we should reconcile what is the proper baseline (I am in "the higher the better" ballpark). We should go 3.6 as baseline (and even then, we cover 3.6.x and 3.8.x that is still a huge time-span).

I don't have a strong opinion about forcing 3.6.x or 3.8.x, but I certainly think we should not forbid that. I'll merge the PR, we can always bump the maven version to a higher one if we want to align plugins.

@gnodet gnodet merged commit ad83009 into apache:master Oct 2, 2021
@slachiewicz
Copy link
Member

@rfscholte
Copy link
Contributor

This commit broke the master the branch on https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-remote-resources-plugin/job/master/ ( you can ignore Build XX-jdk8-m3.5.x_site, I will fix that afterwards )

@rfscholte
Copy link
Contributor

Also, such a change deserves a JIRA ticket, including the message [MRRESOURCES-118] Require Maven 3.2.0.
I've created the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants