Skip to content

Conversation

@rvesse
Copy link
Member

@rvesse rvesse commented Dec 8, 2025

This reverts PR #1423 which added the ci skip text into the default release commit message. This broke many developers workflows because it pushes a choice about CI/CD process into default configuration. If developers genuinely want to skip CI/CD for the release commit then they already had configuration to override the commit message and inject the necessary [ci skip] text. However, the maven-release-plugin itself should not make any assumptions about developers CI/CD setups, nor do anything by default that might cause those to skip release commit builds that developers might be relying upon.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
    • NB The original PR did not have any unit tests associated with it
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@motlin
Copy link

motlin commented Dec 9, 2025

Yes please. I just wasted an hour trying to figure out why my release build stopped working, when it has worked for years.

This reverts PR apache#1423 which added the ci skip text into the default
release commit.  This broke many developers workflows because it pushes
a choice about CI/CD process into default configuration.  If developers
genuinely want to skip CI/CD for the release commit then they already
had configuration to override the commit message and inject the
necessary ci skip text.  However, the maven-release-plugin itself should
not make any assumptions about developers CI/CD setups, nor do anything
by default that might cause those to skip release commit builds that
developers might be relying upon.
@cstamas cstamas added this to the 3.3.1 milestone Dec 9, 2025
@cstamas cstamas added the bug Something isn't working label Dec 9, 2025
@slawekjaranowski slawekjaranowski requested a review from kwin December 9, 2025 15:26
@slawekjaranowski slawekjaranowski self-assigned this Dec 9, 2025
@kwin kwin merged commit f0f28e5 into apache:master Dec 9, 2025
11 checks passed
@slawekjaranowski
Copy link
Member

@kwin thanks for merge ... do you want to care about next release?

If no I can do it.

@kwin
Copy link
Member

kwin commented Dec 9, 2025

I won't have time in the coming days unfortunately, would appreciate if you do this one again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Pull requests that break existing features bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants