Conversation
Sun --> Oracle Update some URLs
pzygielo
reviewed
Dec 12, 2022
Co-authored-by: Piotrek Żygieło <[email protected]>
michael-o
reviewed
Dec 12, 2022
| <answer> | ||
| <p> | ||
| You are on Windows XP with Sun JDK 5 or JDK 6 freshly installed, and when you run <i>mvn javadoc:javadoc</i>, | ||
| You are on Windows XP with Oracle JDK 5 or JDK 6 freshly installed, and when you run <i>mvn javadoc:javadoc</i>, |
Member
There was a problem hiding this comment.
I think you can totally reduce this sentence since there was not Oracle JDK at 5 times, no?
Contributor
Author
There was a problem hiding this comment.
I'm tempted to delete this one entirely since both the Windows and JDK referenced are so old. However, I don't know if this might happen in a nee system or not.
Member
There was a problem hiding this comment.
Delete it. Time to get over it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sun --> Oracle
Oxford comma
update URLs
@michael-o